Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skip slow mode capability not handled #2904

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Conversation

martinmitrevski
Copy link
Contributor

🔗 Issue Links

n/a

🎯 Goal

There's a skip slow mode capability that we didn't handle.

🛠 Implementation

Added the capability check.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

  • Create a channel
  • Enable slow mode
  • Now the permissions are setup so that even when there's a slow mode, the creator can send messages.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

ALT_TEXT

@martinmitrevski martinmitrevski requested a review from a team as a code owner November 20, 2023 17:06
Copy link

github-actions bot commented Nov 20, 2023

1 Warning
⚠️ Please be sure to complete the Contributor Checklist in the Pull Request description

Generated by 🚫 Danger

@martinmitrevski martinmitrevski enabled auto-merge (squash) November 21, 2023 09:40
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 44 Code Smells

90.2% 90.2% Coverage
0.1% 0.1% Duplication

@martinmitrevski martinmitrevski merged commit e2cb9cd into develop Nov 21, 2023
17 checks passed
@martinmitrevski martinmitrevski deleted the slow-mode-fix branch November 21, 2023 10:31
@polqf polqf mentioned this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants