Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marking channel read when isJumpToUnread is disabled #2902

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Nov 17, 2023

🔗 Issue Links

N/A

🎯 Goal

Fix marking channel read when isJumpToUnread is disabled.

🛠 Implementation

The shouldMarkChannelRead logic did not account for the isJumpToUnread flag.

🧪 Manual Testing Notes

  1. Open a channel
  2. Mark a message unread on an old page
  3. Go DemoApp configuration
  4. Uncheck isJumpToUnreadEnabled
  5. Open the same channel
  6. Should mark the channel read when opening the channel
  7. Go back to the channel list
  8. Unread counts should be cleared

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🐞 Bug An issue or PR related to a bug ❗️ High Priority An issue or PR that is marked as a high priority labels Nov 17, 2023
@nuno-vieira nuno-vieira requested a review from a team as a code owner November 17, 2023 19:05
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 44 Code Smells

90.2% 90.2% Coverage
0.1% 0.1% Duplication

@nuno-vieira nuno-vieira merged commit 0b3b089 into develop Nov 17, 2023
17 checks passed
@nuno-vieira nuno-vieira deleted the fix/not-able-to-mark-channel-read-when-jumpToUnread-disabled branch November 17, 2023 23:04
nuno-vieira added a commit that referenced this pull request Nov 17, 2023
* Fix not being able to mark channel read when `isJumpToUnread` is disabled

* Update CHANGELOG.md
@nuno-vieira nuno-vieira mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug ❗️ High Priority An issue or PR that is marked as a high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants