Skip to content

Commit

Permalink
Merge pull request #659 from florian-lst/php84
Browse files Browse the repository at this point in the history
Add PHP 8.4 support
  • Loading branch information
nhovratov authored Jan 10, 2025
2 parents fe98053 + 7975b14 commit e9bb442
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,14 @@ jobs:
run: Build/Scripts/runTests.sh -s unit -p ${{ matrix.php }}

PHPStan:
name: PHPStan TYPO3 13.4 PHP 8.2
name: PHPStan TYPO3 13.4 PHP 8.4
runs-on: ubuntu-latest

steps:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.2
php-version: 8.4

- uses: actions/checkout@v3

Expand Down
2 changes: 1 addition & 1 deletion Classes/CodeGenerator/TcaCodeGenerator.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function __construct(
/**
* Generates and sets the correct tca for all the inline fields
*/
public function setInlineTca(TableDefinitionCollection $tableDefinitionCollection = null): void
public function setInlineTca(?TableDefinitionCollection $tableDefinitionCollection = null): void
{
$this->tableDefinitionCollection = $tableDefinitionCollection ?? $this->tableDefinitionCollection;
foreach ($this->tableDefinitionCollection as $tableDefinition) {
Expand Down

0 comments on commit e9bb442

Please sign in to comment.