NPI-3388 Pandas deprecation fixes and improved SP3 rendering capability (moon orbit capability 🌚 ) #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-deprecation-fixes
…er. Failed on previous attempt but pulled it off this time.
…improve clarity and allow reuse
…ues, reducing conversion steps for output formatting
…for each sp3 epoch
…ing, thanks to updated formatting approach. Add some helpful comments and placeholders from an old stash.
…ed crash on pipeline
…no difference to crash
…n test crashing during sp3 write
…his was missed before
…formatting. This is why the values had initially been misaligned
…frame index while reading an sp3 file with velocities. I have never seen this in practice, but demonstrated it in testing.
|
Further update made to address misalignment of values with full width enabled. It turns out the nodata strings needed updating. |
…ation about why a test including gen_sp3_content() does not use a mock file for input.
ronaldmaj
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been a while in the making. 😅
The motivation for this work, was fixing deprecation issues which would prevent upgrading to Pandas 3.
One of these issues required changing the way
gen_sp3_content()renders values within each epoch.We previously found and replaced
NaNs with string nodata values, within theDataFrameitself. This represented double-handling and is also not allowable in Pandas 3 as it mixed datatypes within a column (we were putting a string nodata value in a numeric column when we found aNaNor+/-inf).We how handle formatting of
infandNaNvalues at the point of rendering, usingStyler'sformat(),hide(), andto_string()functions. This means less double-handling and should improve performance and code clarity. ✨Switching to
Styleralso had an unexpected bonus 🎉 :Styler'sto_string()has adelimiterparameter, and setting this to an empty string allows us to disable padding between columns (which had previously been a bugbear).This change in turn allows us to format position and clock values at the correct width, removing a known limitation in the SP3 rendering code.
Now we can output a file with an orbit as large as that of the moon. 🌚 But we'd probably never need to.