NPI-3683 SP3 consistency check streamlining #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eader representation, to help maintain consistency of that header data. This is useful for example when removing offline sats.
…up by header parser, including a warning for old versions of the format which we may not have tested for
…in the list of SVs - only impact in validation code because things were not well ordered
…ion of SP3 header when it removes an SV from the dataframe
…e sats. Update docstring
…nd various check and clean-up functions, to streamline code and separate concerns. The dataframe should now be more streamlined by the time checks are invoked, meaning the checks have less edge cases to consider.
…new list of SVs. Filtering logic reworked to maintain a unified set of SVs to keep, converting this into a set to drop just before applying. This should avoid the potential to end up with filter_by_name and filter_by_count selecting different SVs and ending up with an empty output. test_file_creation_util.py updated to allow epoch count to remain unchanged, and to use new validation logic when reading files.
ronaldmaj
requested changes
Jan 14, 2025
gnssanalysis/gn_io/sp3.py
Outdated
| @@ -193,14 +196,41 @@ def sp3_clock_nodata_to_nan(sp3_df: _pd.DataFrame) -> None: | |||
| sp3_df.loc[nan_mask, ("EST", "CLK")] = _np.nan | |||
|
|
|||
|
|
|||
| def remove_svs_from_header(sp3_df: _pd.DataFrame, sats_to_remove: set[str]): | |||
There was a problem hiding this comment.
Missing output type hint
| DataFrame. This is useful e.g. when removing offline satellites. | ||
| :param _pd.DataFrame sp3_df: SP3 DataFrame on which to update the header (in place). | ||
| :param list[str] sats_to_remove: list of SV names to remove from the header. | ||
| """ |
There was a problem hiding this comment.
doc string missing output parameter
There was a problem hiding this comment.
There is none; this function operates on the DataFrame passed in, modifying it in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds various restructuring of the SP3 read and validation process, aimed at improving consistency and separating concerns better between stages of the process.
Also:
ORB_TYPEtoINTwhen removing offline sats.remove_svs_from_header()utility function for removing sats from internal header, so we can better maintain header consistency when performing operations likeremove_offline_sats()filter_by_svs(), reworking the removal logic to only calldrop()once, and to update the internal header to reflect the new list of sats.