-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSoC 2024 dingo blog #35
base: gh-pages
Are you sure you want to change the base?
GSoC 2024 dingo blog #35
Conversation
@@ -0,0 +1,119 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SotirisTouliopoulos! That looks good. A general comment is that the text is more like a gsoc final submission. I would make a few modifications so that it would be more like a blog-post.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! :)
Let me know if you need anything from my side.
|
||
This figure illustrates a heatmap from a symmetrical correlation matrix without pearson or indicator filtering: | ||
<center> | ||
<img src="https://sotiristouliopoulos.github.io/dingo/img/corr_matrix_no_cutoffs.png"><br><br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have figures of high resolution; when you are trying to zoom in to check the reaction names you get pixels now.
General comment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, I have a few comments/questions.
|
||
When an object is initialized from the `PreProcess` class, users can call the `reduce` function on this object to remove three types of reactions: | ||
|
||
- Blocked reactions: cannot carry a flux in any condition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the meaning of "carry a flux"? Is it standard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is standard. It is mentioned in this article: https://doi.org/10.1038/msb.2010.47
_posts/2024-08-24-GSoC2024-dingo.md
Outdated
removed_reactions, reduced_dingo_model = obj.reduce(extend = False) | ||
``` | ||
|
||
Reduction with the `PreProcess` class has been tested with various models from the BiGG database <a href="#ref-2">[2]</a>. Figures below show the number of remained reactions, after applying the `reduce` function: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to have two instead of one plot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better visibility. Lines overlapped when all reactions were in a single plot
Figures are loaded from my evaluation blog, because i could not find a way to load them from a folder