Convert to System.Text.Json #151
Conversation
removing JsonProperty alltogether where the PropertyName matches the property name. The property naming convention is set on the STJ JsonSerializerOptions
users can use built in JsonStringEnumConverter(with a naming policy)
only public properties are seralized. A [JsonIgnore] attribute should be used to exclude unwanted properties
These will need custom converters since STJ only support empty constructors.
|
@xfischer, @xperiandri, and @matt-lethargic I'd love to get some early participation with this |
|
@steveoh amazing start, I made a start as well, but got bogged down learning the new JsonSerializer. I'm happy to commit this PR into v2 as WIP. I've also invited you so you can work straight into v2 if you'd like |
|
Someone is going to have to refactor all of the tests since they are depending on json.net serialization instead of static strings which isn't awesome. |
|
Can we use c# 9 in this project? I wouldn't think it would matter much to users but I figured I'd ask. |
|
Yep
…On Thu, 3 Sep 2020, 17:37 steveoh, ***@***.***> wrote:
Can we use c# 9 in this project? I wouldn't think it would matter much to
users but I figured I'd ask.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#151 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACFVWTILPZZUF6ECBLHKSTSD7A2XANCNFSM4QT2TKTA>
.
|
use preview language features for pattern matching
this will need to be replaced some how
|
99 tests passing only 10 left to go. I hope you are ok with my implementation. Please tell me that you have at least glanced at it already? |
|
all the tests are now passing. do with it what you want. thanks for all of the support |
there are no tests covering this
|
I think i'm going to use https://github.com/NetTopologySuite/NetTopologySuite.IO.GeoJSON/blob/develop/src/NetTopologySuite.IO.GeoJSON4STJ as their implementation looks much nicer than what I did. You might reference this if you ever get around to it. FYI, I will delete my fork in the coming days. |
|
@steveoh I'm sorry the story ends like this. We're just two (three with you) maintaining this repo. I am very busy lately so that I couldn't support all the great work you were doing. Sorry about that, and I believe it's the same for @matt-lethargic. |
refs #148