Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move serializers to a separate project and NuGet to support System.Text.Json in another project and NuGet #148

Open
xperiandri opened this issue Jun 20, 2020 · 5 comments

Comments

@xperiandri
Copy link

Create a new project for NewtonSoft.JSON serializers and issue them as a separate NuGet package

@matt-lethargic
Copy link
Member

@xfischer I've been looking at the issues that System.Text.Json has brought about and thinking that this could be a solution in a v2 of GeoJSON.Net.

  • Natively support System.Text.Json
  • Contrib lib for Json.Net

Thoughts?

@xfischer
Copy link
Member

Yes I agree to set System.Text.Json as the default (de)serializer, and provide backwards compatibility as a separate NuGet package, as suggested by @xperiandri.
Let's create a branch for that purpose and get started. @matt-lethargic did you look how to migrate existing converters ? As I saw quickly it seems like a lot of work to support System.Text.Json, but hopefully we are covered with unit tests.

I'll take care of the Contribs in a similar new-branch approach.

Related MS docs :

@matt-lethargic
Copy link
Member

I haven't looked at the migration properly yet, but have docs in front of me.
Will start a v2 branch

@steveoh
Copy link

steveoh commented Sep 2, 2020

I've been migrating a similar project to STJ and it's not that bad. I was going to fork this for my project but I am glad that it is on your radar and I am happy to contribute. How's the progress so far?

@steveoh
Copy link

steveoh commented Sep 3, 2020

Since there wasn't any visible progress, I went ahead and forked. Please provide some early feedback and participate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants