Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Install pandas 2.1 + pyarrow in the Python 3.11 job #3605

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Nov 9, 2024

As mentioned in PR #3584, pandas dtype conversion behaviors change in pandas 2.2., so we need to test both pandas<2.2 and pandas>=2.2 in our CI jobs. Our CI jobs already do this since we install pandas=2.0 in the Python 3.10 CI job and pandas latest version (2.2) in the Python 3.12 CI job.

However, pandas also supports pyarrow as its array backend, and pyarrow is an optional dependency. Currently only the Python 3.12 CI job has pyarrow installed, leaving the pandas<2.2 + pyarrow untested.

I don't think we want to add more CI jobs, so this PR installs pandas 2.1 and pyarrow in the Python 3.11 job instead.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels Nov 9, 2024
@seisman seisman added this to the 0.14.0 milestone Nov 9, 2024
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Nov 11, 2024
@seisman seisman requested a review from a team November 11, 2024 01:25
.github/workflows/ci_tests.yaml Outdated Show resolved Hide resolved
Co-authored-by: Wei Ji <[email protected]>
@seisman seisman changed the title CI: Install pandas 2.0 + pyarrow in the Python 3.11 job CI: Install pandas 2.1 + pyarrow in the Python 3.11 job Nov 11, 2024
@seisman seisman merged commit ff9daae into main Nov 11, 2024
15 of 16 checks passed
@seisman seisman deleted the ci/pyarrow+pandas2.0 branch November 11, 2024 02:43
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Nov 11, 2024
weiji14 added a commit that referenced this pull request Nov 11, 2024
PyArrow's dependencies (specifically sparse and numba) aren't supported on Python 3.13 yet, so removing for now since PyArrow is included in the Python 3.11 CI build (#3605). Downgraded Python version in environment.yml from =3.13 to >=3.10
@weiji14 weiji14 mentioned this pull request Nov 11, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants