clib.conversion._to_numpy: Add tests for Python list of strings and NumPy array with string type #3601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umPy array with string type
seisman
added
maintenance
32 tasks
seisman
commented
Nov 8, 2024
|
It's unclear what's happening with the Python 3.10 + macOS CI job. It started to fail since PR #3599, but changes in PR #3599 are totally unrelated since pyarrow is not installed in the Python 3.10 + macOS CI job and the failing tests are all about grdcontour and grdimage. What's more weird is that the same CI job then passes in #3584. In PR #3606, I tried to bump our minimum supported Python version to 3.11 and the CI jobs pass, so I think we can ignore the Python 3.10 failures. |
michaelgrund
approved these changes
Nov 12, 2024
michaelgrund
added
final review call
weiji14
approved these changes
Nov 12, 2024
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Python's list of strings and NumPy's string arrays.
Related to #3600.