CI: Pin actions/upload-artifact and peter-evans/slash-command-dispatch to the latest tag #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h to the latest tag
seisman
added
maintenance
seisman
commented
Sep 9, 2024
| with: | ||
| name: gmt-cache | ||
| include-hidden-files: true |
There was a problem hiding this comment.
In v4.4.0, include-hidden-files is false by default. Here we set it to true.
The workflow runs as expected: https://github.com/GenericMappingTools/pygmt/actions/runs/10769413727?pr=3431
seisman
commented
Sep 9, 2024
seisman
commented
Sep 9, 2024
| @@ -14,7 +14,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - name: Slash Command Dispatch | |||
| uses: peter-evans/slash-command-dispatch@v4 | |||
| uses: peter-evans/slash-command-dispatch@v4.0.0 | |||
There was a problem hiding this comment.
seisman
added
final review call
weiji14
approved these changes
Sep 10, 2024
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The actions/upload-artifact v4.4.0 introduced a breaking change, which excludes hidden files by default. This new version breaks the workflow in one of my repositories (here is the workflow run https://github.com/gmt-china/GMT_docs/actions/runs/10759759418 if you're interested). The new version should also affect our "Cache Data" workflow, since we upload the files in
~/.gmt, but actually the workflow is not affected (likely because we run it under macOS).Anyway, it's always a good idea to pin actions to a specific tag so that workflows won't break suddenly due to upstream changes.