-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for plotting global grid without the redundant 360 longitude #3358
Conversation
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Report last updated at commit 86b6d7d |
This comment was marked as outdated.
This comment was marked as outdated.
Maybe best if we keep the original |
Actually the original issue is not due to the missing 360 longitude. For any grids that is not exactly 0-360, the same issue occurs for central longitude < 180 and for specific projections. If interested, you can play with the script in #3331 (comment). |
Co-authored-by: Yvonne Fröhlich <[email protected]>
Description of proposed changes
This PR adds a test for the bug reported in #3331. See #3331 (comment) for the comprehensive tests for when the bug can be triggered. This PR only test the central longitude=120 case. The baseline image is created by saving
da3
/da4
into a netCDF file and passing the netCDF files directly toFig.grdimage
.The new test only passes with the upstream fix in GenericMappingTools/gmt#8554. So, the test is marked as xfail for GMT<=6.5.0.
The test passes in the "GMT Dev Tests" workflow: https://github.com/GenericMappingTools/pygmt/actions/runs/11138377051?pr=3358
Closes #3331.