non_ascii_to_octal: Return the input string if it only contains printable ASCII characters #3199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The
non_ascii_to_octal
function was added in #2584 to convert any non-ASCII characters in a string to the corresponding octal codes. It's applied to all argument strings and texts passed inFigure.text
. In most cases, we don't use non-ASCII characters, so applying this function is not necessary.This PR improve the
non_ascii_to_octal
function so that it simply return the input string if the input string doesn't contain any non-ASCII characters.Here is the benchmark.
Main branch
This PR
For strings that don't contain any non-ASCII characters, this PR is much faster (5.8 µs vs 243 µs).