Figure.text: Improve the documentation to clarify the order of columns in the input files #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in the input files
seisman
added
skip-changelog
seisman
changed the title
Co-authored-by: Yvonne Fröhlich <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
| * *y*: Y coordinate or latitude | ||
| * *angle*: Angle in degrees counter-clockwise from horizontal | ||
| * *font*: Text size, font, and color | ||
| * *justify*: Two-character justification code |
There was a problem hiding this comment.
Here we write currently two-character justification code. But we write
- below for the
justifyparametertwo-letter combination - in the colorbar example
2-character combination - in the text tutorial
two-letter (order independent) code - etc.
I think it would be nice to formulate this consistently. This is a bit related to issue #2834. I will try to find time to look at this in more detail; currently busy with other things.
There was a problem hiding this comment.
Yes, we can simplify these descriptions if issue #2834 is addressed.
There was a problem hiding this comment.
Then maybe we leave these formulations as they are for now, and make it consistent via addressing #2834 🙂.
yvonnefroehlich
approved these changes
Dec 4, 2023
seisman
added
final review call
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://pygmt-dev--2832.org.readthedocs.build/en/2832/api/generated/pygmt.Figure.text.html#pygmt.Figure.text
Address #479 (comment)
Closes #479.