-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add load_moon_relief to load Moon relief dataset in various resolutions and registrations #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
seisman
changed the title
load_moon_relief: Load moon relief dataset in various resolutions and registrations
WIP: load_moon_relief: Load moon relief dataset in various resolutions and registrations
Sep 9, 2023
7 tasks
seisman
commented
Sep 14, 2023
yvonnefroehlich
added a commit
that referenced
this pull request
Sep 14, 2023
Co-authored-by: Michael Grund <[email protected]>
seisman
commented
Sep 15, 2023
seisman
changed the title
WIP: load_moon_relief: Load moon relief dataset in various resolutions and registrations
load_moon_relief: Load moon relief dataset in various resolutions and registrations
Sep 15, 2023
seisman
changed the title
load_moon_relief: Load moon relief dataset in various resolutions and registrations
DO NOT MERGE: Add load_moon_relief to load Moon relief dataset in various resolutions and registrations
Sep 15, 2023
seisman
changed the title
DO NOT MERGE: Add load_moon_relief to load Moon relief dataset in various resolutions and registrations
RFC: DO NOT MERGE: Add load_moon_relief to load Moon relief dataset in various resolutions and registrations
Oct 28, 2023
seisman
commented
Dec 3, 2023
seisman
commented
Dec 3, 2023
name="moon relief", | ||
long_name="Moon relief", | ||
units="meters", | ||
extra_attributes={}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that extra_attributes
is empty here because I have no idea about the horizontal_datum
attribute for the dataset.
seisman
force-pushed
the
load_moon_relief
branch
from
December 21, 2023 09:11
af1a987
to
c53b96e
Compare
seisman
changed the title
RFC: DO NOT MERGE: Add load_moon_relief to load Moon relief dataset in various resolutions and registrations
Add load_moon_relief to load Moon relief dataset in various resolutions and registrations
Dec 26, 2023
seisman
force-pushed
the
load_moon_relief
branch
from
January 14, 2024 08:56
6baf2c7
to
8ee71cf
Compare
Co-authored-by: Yvonne Fröhlich <[email protected]>
seisman
commented
Jan 21, 2024
seisman
commented
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Preview: https://pygmt-dev--2674.org.readthedocs.build/en/2674/api/generated/pygmt.datasets.load_moon_relief.html
Address #2431.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version