Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix the ci-caches workflow and always use the "static" data server in CI #8426

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 7, 2024

Description of proposed changes

@seisman seisman changed the title CI: Update the ci-caches workflow CI: Fix the ci-caches workflow and always use the "static" data server in CI Apr 10, 2024
@seisman seisman added the maintenance Boring but important stuff for the core devs label Apr 10, 2024
@seisman seisman added this to the 6.6.0 milestone Apr 10, 2024
@seisman seisman marked this pull request as ready for review April 10, 2024 14:41
@seisman
Copy link
Member Author

seisman commented Apr 10, 2024

With changes in this PR, now all tests pass on macOS and Windows. In Linux CI, following tests fail:

	509 - test/grdfill/gridfill.sh (Failed)
	521 - test/grdgdal/gdal_nn.sh (Failed)
	552 - test/grdimage/image_vartrans.sh (Failed)
	647 - test/grdvector/shrink.sh (Failed)
	702 - test/mapproject/proj4.sh (Failed)
	738 - test/nearneighbor/nat_nn.sh (Failed)
	754 - test/potential/firmoviscous.sh (Timeout)
	755 - test/potential/firmoviscous2.sh (Timeout)

Not sure why firmoviscous tests timeout in CI. They work well for me locally.

@seisman seisman requested a review from joa-quim April 10, 2024 15:47
@joa-quim
Copy link
Member

Do the other tests fail for you as well on Linux?

The *_nn.sh failures are extremely irritating for me. I spent awful long time figuring out why originally they failed and it turned out to be a GDAL version issue. Since ~2 years(?) now we have a test on GDAL version to that, but it insists in failing under Linux.

And why is proj4.sh failing?

@seisman
Copy link
Member Author

seisman commented Apr 10, 2024

better to merge this PR first so that I can look into the details of the failing tests.

@seisman seisman merged commit 8fd8986 into master Apr 10, 2024
18 of 20 checks passed
@seisman seisman deleted the cache-data branch April 10, 2024 22:41
seisman added a commit to seisman/gmt that referenced this pull request Apr 12, 2024
@seisman
Copy link
Member Author

seisman commented Apr 15, 2024

With changes in this PR, now all tests pass on macOS and Windows. In Linux CI, following tests fail:

	509 - test/grdfill/gridfill.sh (Failed)
	521 - test/grdgdal/gdal_nn.sh (Failed)
	552 - test/grdimage/image_vartrans.sh (Failed)
	647 - test/grdvector/shrink.sh (Failed)
	702 - test/mapproject/proj4.sh (Failed)
	738 - test/nearneighbor/nat_nn.sh (Failed)
	754 - test/potential/firmoviscous.sh (Timeout)
	755 - test/potential/firmoviscous2.sh (Timeout)

Not sure why firmoviscous tests timeout in CI. They work well for me locally.

I have gridfill.sh, image_vartrans.sh and shrink.sh failing for me on Linux, and all other tests pass.

I have GDAL 3.7.3 installed and the Linux CI has GDAL 3.4.1.

@seisman
Copy link
Member Author

seisman commented Apr 15, 2024

image

The *_nn.sh fail with up-down flip. Left is the correct one and right is the wrong one.

@joa-quim
Copy link
Member

I have GDAL 3.7.3 installed and the Linux CI has GDAL 3.4.1.

... typical of Ubuntu

I have a vague recall that the condition to workaround the GDAL issue was for GDAL 3.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants