Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @loader_path for building the bundle #6379

Closed
wants to merge 1 commit into from
Closed

Conversation

maxrjones
Copy link
Member

Description of proposed changes

As proposed in #1930 (comment), this PR updates cmake/dist/CMakeLists.txt to use @loader_path rather than @executable_path.

Relates to #1930, #6128, and #4246.

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@maxrjones maxrjones added the maintenance Boring but important stuff for the core devs label Mar 1, 2022
@maxrjones
Copy link
Member Author

Closing as stale

@maxrjones maxrjones closed this Jan 11, 2024
@maxrjones maxrjones deleted the cmake-loader_path branch January 11, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant