fix(website): title of sequences by location component on sequencing …

…efforts pages (#463) resolves #434
GenSpectrum · Jan 13, 2025 · 6b09aef · 6b09aef
1 parent ee6d860
commit 6b09aef
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/website/src/components/views/sequencingEfforts/GenericSequencingEffortsPage.astro b/website/src/components/views/sequencingEfforts/GenericSequencingEffortsPage.astro
@@ -31,11 +31,10 @@ const timeGranularity = chooseGranularityBasedOnDateRange(
     pageState.datasetFilter.dateRange,
     new Date(view.organismConstants.earliestDate),
 );
-const {
-    label: locationLabel,
-    locationField,
-    mapName,
-} = getLocationDisplayConfig(view.organismConstants.locationFields, pageState.datasetFilter.location);
+const { locationField, mapName } = getLocationDisplayConfig(
+    view.organismConstants.locationFields,
+    pageState.datasetFilter.location,
+);
 const lineageFilterConfigs = getLineageFilterConfigs(
     view.organismConstants.lineageFilters,
     pageState.variantFilter.lineages,
@@ -87,7 +86,7 @@ const lineageFilterConfigs = getLineageFilterConfigs(
         {
             locationField !== undefined && (
                 <GsSequencesByLocation
-                    title={locationLabel}
+                    title='Sequences by location'
                     height={ComponentHeight.large}
                     lapisLocationField={locationField}
                     lapisFilter={lapisFilter}

diff --git a/website/src/views/locationHelpers.spec.ts b/website/src/views/locationHelpers.spec.ts
@@ -13,7 +13,7 @@ describe('getLocationDisplayConfig', () => {
 
         const actual = getLocationDisplayConfig(locationFields, locationFilter);
 
-        const expected = { label: 'World', mapName: 'World', locationField: countryField };
+        const expected = { mapName: 'World', locationField: countryField };
         expect(actual).toEqual(expected);
     });
 
@@ -25,7 +25,6 @@ describe('getLocationDisplayConfig', () => {
         const actual = getLocationDisplayConfig(locationFields, locationFilter);
 
         const expected = {
-            label: 'Country',
             mapName: 'myContinentValue',
             locationField: countryField,
         };
@@ -41,7 +40,6 @@ describe('getLocationDisplayConfig', () => {
         const actual = getLocationDisplayConfig(locationFields, locationFilter);
 
         const expected = {
-            label: 'Geographic sub-divisions',
             mapName: 'myCountryValue',
             locationField: divisionField,
         };

diff --git a/website/src/views/locationHelpers.ts b/website/src/views/locationHelpers.ts
@@ -4,12 +4,11 @@ import { hasOnlyUndefinedValues } from '../util/hasOnlyUndefinedValues.ts';
 export function getLocationDisplayConfig(locationFields: string[], locationFilter: LapisLocation) {
     if (hasOnlyUndefinedValues(locationFilter)) {
         const locationField = locationFields.find((it) => isCountryField(it)) ?? locationFields[0];
-        return { label: 'World', mapName: 'World', locationField };
+        return { mapName: 'World', locationField };
     }
 
-    const { label, locationValue, field } = getLocationSubdivision(locationFields, locationFilter);
+    const { locationValue, field } = getLocationSubdivision(locationFields, locationFilter);
     return {
-        label,
         mapName: locationValue,
         locationField: field,
     };