fix(components): gs-mutations-over-time: show 0 instead of "no data" when there are sequences but no mutation #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.11.6 (2025-01-13)FeaturesBug Fixes |
fengelniederhammer
force-pushed
the
635-mutations-over-time-wrongly-determined-as-no-data-case-2
branch
from
666709a to
621c19b
Compare
anna-parker
reviewed
Jan 10, 2025
anna-parker
reviewed
Jan 10, 2025
components/src/preact/mutationsOverTime/__mockData__/aminoAcidMutationsByDay.ts
Outdated
Show resolved
Hide resolved
anna-parker
reviewed
Jan 10, 2025
JonasKellerer
approved these changes
Jan 13, 2025
...load-of-visualization-mutations-over-time--by-week-should-match-snapshot-1-firefox-linux.txt
Outdated
Show resolved
Hide resolved
…when there are sequences but no mutation (#635 case 2)
fengelniederhammer
force-pushed
the
635-mutations-over-time-wrongly-determined-as-no-data-case-2
branch
from
621c19b to
74f3238
Compare
fengelniederhammer
deleted the
635-mutations-over-time-wrongly-determined-as-no-data-case-2
branch
This was referenced Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #635 case 2
Summary
Logic before:
If a certain time interval didn't have a certain mutation (corresponding to a cell in the mutations over time grid), we would leave the data empty -> It would display "no data", although we have sequences in that time interval.
Logic after:
If we have >0 sequences in a time interval, we fill up all empty grid cells with 0, because we have data, but the data doesn't have that mutation there. "no data" should only be shown when there is no data in that time interval in LAPIS (i.e. aggregated returns count 0).
-> A column of the grid will either have data in all cells or the whole column will show "no data".
Screenshot
PR Checklist
- [ ] All necessary documentation has been adapted.