feat(components): gs-aggregate: add bar chart view #639
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.11.5 (2025-01-09)Features |
| @@ -28,6 +29,7 @@ const aggregatePropsSchema = z.object({ | |||
| pageSize: z.union([z.boolean(), z.number()]), | |||
| width: z.string(), | |||
| height: z.string(), | |||
| maxNumberOfBars: z.number(), | |||
There was a problem hiding this comment.
Do we want to already name this to something that we dont have to change later on, when we have pagination? I imagine that this could be pageSizeBars, or something. But maybe this is misleading for now.
There was a problem hiding this comment.
I can imagine that pagination would be a breaking change anyway, but I'm not sure. Also even with pagination, I wouldn't find maxNumberOfBars so bad.
But for now I would stick with this name. It's not clear whether we will introduce pagination -> let's have a non-confusing name for now.
I added it. |
resolves #546
Summary
maxNumberOfBarsthat controls how many bars are shown. Maybe we can implement pagination or similar later.(I added corresponding tasks to the parent epic)
Screenshot
With one
field:With two
fields:PR Checklist