Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutations over time: wrongly determined as "no data"? #635

Open
chaoran-chen opened this issue Jan 5, 2025 · 0 comments · May be fixed by #644
Open

Mutations over time: wrongly determined as "no data"? #635

chaoran-chen opened this issue Jan 5, 2025 · 0 comments · May be fixed by #644
Labels
bug Something isn't working components Regarding the components

Comments

@chaoran-chen
Copy link
Member

chaoran-chen commented Jan 5, 2025 •
edited
Loading

Case 1: On this page, every mutation is displayed as having only "no data":

image

Case 2: On this page, it shows that there is no data for ORF1a:I1367L in week 27 (2024-07-01 to 2024-07-07) but this page confirms that we do have coverage for the position in that week. In fact, there are three samples that do not have a mutation at the position (ORF1a:I1367I). So, for ORF1a:I1367L, we would have 0% instead of no data.
@chaoran-chen chaoran-chen added bug Something isn't working components Regarding the components labels Jan 5, 2025
fengelniederhammer added a commit that referenced this issue Jan 9, 2025
@fengelniederhammer
fix(components): fix lastDay of YearWeekClass (#635 case 1)
247a869 
The `lastDay`s in 2021 and 2022 were off by 7 days.
"2022-W01" would show "first day 2022-01-03" and "last day "2022-01-02".
Thus, the mutation over time cells would be empty.
@fengelniederhammer fengelniederhammer mentioned this issue Jan 9, 2025
Merged
1 task
fengelniederhammer added a commit that referenced this issue Jan 9, 2025
@fengelniederhammer
fix(components): fix lastDay of YearWeekClass (#635 case 1) (#641)
e56c5a9 
The `lastDay`s in 2021 and 2022 were off by 7 days.
"2022-W01" would show "first day 2022-01-03" and "last day "2022-01-02".
Thus, the mutation over time cells would be empty.
@github-actions github-actions bot mentioned this issue Jan 9, 2025
Merged
fengelniederhammer added a commit that referenced this issue Jan 9, 2025
@fengelniederhammer
fix(components): gs-mutations-over-time: show 0 instead of "no data" …
71d1057 
…when there are sequences but no mutation

resolves #635 case 2
fengelniederhammer added a commit that referenced this issue Jan 9, 2025
@fengelniederhammer
fix(components): gs-mutations-over-time: show 0 instead of "no data" …
666709a 
…when there are sequences but no mutation

resolves #635 case 2
@fengelniederhammer fengelniederhammer linked a pull request Jan 9, 2025 that will close this issue
Open
1 task
fengelniederhammer added a commit that referenced this issue Jan 9, 2025
@fengelniederhammer
fix(components): gs-mutations-over-time: show 0 instead of "no data" …
621c19b 
…when there are sequences but no mutation (#635 case 2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working components Regarding the components
Projects
None yet
Milestone
No milestone
1 participant
@chaoran-chen