Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return an error if reserved value INT32_MIN is used in filter #670

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Taepper
Copy link
Collaborator

@Taepper Taepper commented Jan 7, 2025

resolves #636

Summary

The value INT32_MIN is currently reserved in an Integer column. This fixes the bug, that a user could still filter for that value and receive unexpected results.

PR Checklist

  • All necessary documentation has been adapted or there is an issue to do so.
  • The implemented feature is covered by an appropriate test.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog.

Note that this might contain changes that are on main, but not yet released.

Changelog:

0.5.0 (2025-01-07)

⚠ BREAKING CHANGES

  • new command line / config system

Features

  • add materializationCutoff option (8920d5f)
  • new command line / config system (2a29074), closes #633

Bug Fixes

  • declare virtual constructor for abstract base class CustomSqlFunction (603ddf6)
  • return an error if reserved value INT32_MIN is used in filter (c310ef9)

@Taepper Taepper force-pushed the 636-filtering-for-INT32_MIN-should-error branch from 11790c5 to c310ef9 Compare January 7, 2025 08:20
@Taepper Taepper merged commit 042646b into main Jan 7, 2025
9 checks passed
@Taepper Taepper deleted the 636-filtering-for-INT32_MIN-should-error branch January 7, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering for INT32_MIN should error
2 participants