Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README and docker compose improvement #667

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

Taepper
Copy link
Collaborator

@Taepper Taepper commented Dec 18, 2024

resolves #

Summary

improve README.md and remove superfluous database_config mount in the docker compose for ci.

The help text already mentioned that the database_config is relative to the input directory.:

         ConfigAttributeSpecification::createWithDefault(
            databaseConfigFileOptionKey(),
            ConfigValue::fromPath("database_config.yaml"),
            "File name of the file holding the database table configuration. Relative from "
            "input_directory."
         ),

Maybe this should have also been in the change-log?

PR Checklist

  • All necessary documentation has been adapted or there is an issue to do so.
    - [ ] The implemented feature is covered by an appropriate test.

Copy link
Contributor

This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog.

Note that this might contain changes that are on main, but not yet released.

Changelog:

0.5.0 (2024-12-18)

⚠ BREAKING CHANGES

  • new command line / config system

Features

  • add materializationCutoff option (8920d5f)
  • new command line / config system (2a29074), closes #633

Bug Fixes

  • declare virtual constructor for abstract base class CustomSqlFunction (603ddf6)

@fengelniederhammer fengelniederhammer merged commit ae03f00 into main Dec 19, 2024
9 checks passed
@fengelniederhammer fengelniederhammer deleted the readme-and-docker-compose-improvement branch December 19, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants