Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: erroneous file created during unit tests should not leak #466

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

Taepper
Copy link
Collaborator

@Taepper Taepper commented Jun 6, 2024

Summary

One can persist the duckdb database that is used during preprocessing for debugging purposes. I didn't remove this option in one of the unit tests. Because the unit tests are run from the repository's root directory, this debug file was also created in that location. This is now removed.

PR Checklist

- [ ] All necessary documentation has been adapted or there is an issue to do so.
- [ ] The implemented feature is covered by an appropriate test.

@Taepper Taepper requested a review from pflanze June 6, 2024 13:28
@Taepper Taepper force-pushed the fix-debugduckdb branch from b5f8109 to 9a1e120 Compare June 6, 2024 13:28
@Taepper Taepper merged commit 1b764af into main Jun 7, 2024
9 checks passed
@Taepper Taepper deleted the fix-debugduckdb branch June 7, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants