chore(deps): use Ubuntu 24.04 as base image, update dependencies #422
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
corneliusroemer
force-pushed
the
dependabot/docker/ubuntu-24.04
branch
from
8840589 to
308b034
Compare
corneliusroemer
changed the title
corneliusroemer
force-pushed
the
dependabot/docker/ubuntu-24.04
branch
from
2d0e77e to
390211b
Compare
corneliusroemer
changed the title
corneliusroemer
force-pushed
the
dependabot/docker/ubuntu-24.04
branch
from
80fa359 to
071d3b1
Compare
corneliusroemer
force-pushed
the
dependabot/docker/ubuntu-24.04
branch
6 times, most recently
from
8c4943e to
3585233
Compare
corneliusroemer
force-pushed
the
dependabot/docker/ubuntu-24.04
branch
from
3585233 to
98298ef
Compare
|
I have a gutfeeling that performance of the ubuntu based image is much better than of the alpine one. I haven't benchmarked, maybe someone can have a go? |
| && cp build/silo_test . \ | ||
| && cp build/siloApi . | ||
|
|
||
|
|
||
| FROM alpine:3.18 AS server | ||
| FROM ubuntu:24.04 AS server |
There was a problem hiding this comment.
@corneliusroemer, I think that it is better to use small images with as few dependencies as possible to reduce the surface for potential security vulnerabilities.
There was a problem hiding this comment.
I have no strong feelings about this. But I have it on my TO-DO list now, to benchmark the actual images against one another in the next weeks!
|
It turns out that @corneliusroemer was right, I ran the simple benchmark to test preprocessing speeds (used for #509): run the binary directly: |
|
Hah! I don't know what I based my gutfeeling on - but I remember with Nextclade we got much worse multi-threading performance with musl (libc in Alpine) compared to glibc (Ubuntu). |
|
Done in #519 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps ubuntu from 22.04 to 24.04.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)