New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make C++ flags in CMake compatible for MacOS #281

Merged

Taepper merged 1 commit into main from cmake-flags

Feb 7, 2024

Collaborator

Taepper commented Feb 7, 2024

Currently I need to take out some flags when building for Mac locally, this adds it to the CMakeLists.txt and is triggered only for Mac


          fix: Make C++ flags in CMake compatible for MacOS

38cae69

Taepper force-pushed the cmake-flags branch from 7e9e2ac to 38cae69 Compare

February 7, 2024 09:54

JonasKellerer self-requested a review

February 7, 2024 10:09

JonasKellerer approved these changes

View reviewed changes

Contributor

JonasKellerer left a comment

LGTM. (But I can not test, since I dont have a mac :) )

Taepper merged commit 855db59 into main

6 checks passed

Taepper deleted the cmake-flags branch

February 7, 2024 10:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet