-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unaligned Sequences #255
Merged
Merged
Unaligned Sequences #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Taepper
requested review from
JonasKellerer
and removed request for
JonasKellerer
January 23, 2024 15:19
JonasKellerer
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Nice addition.
My comments are mostly for small refactors. However, the add_sequences_to_results_for_partition
function was quite hard to read. If possible, splitting into smaller function would help.
Closed
Taepper
force-pushed
the
unaligned-sequences
branch
3 times, most recently
from
January 24, 2024 09:16
b326e04
to
92c3278
Compare
…e or fasta file and make them queryable via the Fasta action
Taepper
force-pushed
the
unaligned-sequences
branch
from
January 24, 2024 12:29
92c3278
to
44df849
Compare
# Conflicts: # src/silo/preprocessing/preprocessor.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: introduce storage of unaligned sequences from either ndjson file or fasta file and make them queryable via the Fasta action
The last required action
#112 is now very easy (for unaligned), where we can stream the sequences almost directly from the backing file