refactor: minor edits for linter and compile warnings in release mode

GenSpectrum · Feb 1, 2024 · 5301657 · 5301657
1 parent a16a763
commit 5301657
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/silo/common/data_version.test.cpp b/src/silo/common/data_version.test.cpp
@@ -6,7 +6,7 @@ using silo::DataVersion;
 
 TEST(DataVersion, shouldMineDataVersionFromUnixTime) {
    const auto mined_version = DataVersion::mineDataVersion();
-   EXPECT_EQ(mined_version.toString().size(), 10);
+   EXPECT_EQ(mined_version.toString().size(), 10UL);
    EXPECT_EQ(mined_version.toString()[0], '1');
 }
 

diff --git a/src/silo/query_engine/actions/fasta.cpp b/src/silo/query_engine/actions/fasta.cpp
@@ -118,7 +118,6 @@ void addSequencesFromResultTableToJson(
          auto current_key = table_reader.next(genome_buffer);
          assert(current_key.has_value());
          if (genome_buffer.has_value()) {
-            // NOLINTNEXTLINE(bugprone-unchecked-optional-access)
             results.query_result.at(idx).fields.emplace(sequence_name, *genome_buffer);
          } else {
             results.query_result.at(idx).fields.emplace(sequence_name, std::nullopt);