Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3
This is a first version for the framework we envisioned.
The general idea: The test runner automatically detects all testset folders and starts a corresponding
-> This makes the barrier to add new tests very low. Just copy paste an old directory or other data that is found and no need to adjust any config file
For every testset all queries are executed. I know that in #1 it was wished not to be defined in json, but this was closer to what we also did similar in SILO so I started with this and hoped we could iterate on it afterwards.
The queries must be able to define their result in external files, which is currently also the only version of specifying query results.
There are still some things that do not quite work well. The docker-compose file and thus the connection between SILO and LAPIS is sometimes broken and LAPIS throws some Java Exception when a request is received (related to GenSpectrum/LAPIS#934):