Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the story change emitter and on initial load as well as on story and group change. #67

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

Ashu1823
Copy link
Contributor

@Ashu1823 Ashu1823 commented Oct 17, 2024

On every story change if the it is initial load then the previous story details will be null and for others the the previous details will populate.

Issue ticket number and link - (#25)

Checklist before requesting a review

  • I have performed a self-review of my code.

  • Followed the repository's Contributing Guidelines.

  • I ran the app and tested it locally to verify that it works as expected.

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ngx-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 0:50am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Ashu1823, Thanks for contributing and Congrats on opening PR 🎉.

We will try to review as soon as possible and a maintainer will get back to you soon!

@Ashu1823
Copy link
Contributor Author

Hi @Gauravdarkslayer,
I have added the new emitter. Please review the PR and tell me the changes if anything will be there.

Copy link
Owner

@Gauravdarkslayer Gauravdarkslayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR, merging this as there are no further actions required. 🎉

@Gauravdarkslayer Gauravdarkslayer merged commit 1a0d43c into Gauravdarkslayer:main Oct 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants