Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ftr: Add left/right arrow buttons on desktop view only #58

Merged
merged 9 commits into from
Oct 13, 2024
Merged

ftr: Add left/right arrow buttons on desktop view only #58

merged 9 commits into from
Oct 13, 2024

Conversation

meetbhalodi11
Copy link
Contributor

Changes:
added left right navigation buttons for desktop view
added media query for showing those buttons on desktop view only (min screen size: 1024px)

Checklist before requesting a review

  • [o] I have performed a self-review of my code.
  • [o] Followed the repository's Contributing Guidelines.
  • [o] I ran the app and tested it locally to verify that it works as expected.
  • [o] I have starred the repository.

Closes #17

Meet Bhalodi added 2 commits October 12, 2024 12:30
ftr: Add left/right arrow buttons on desktop view only
c7c0aa4 
added left right navigation buttons for desktop view
added media query for showing those buttons on desktop view only (min screen size: 1024px)
Merge branch 'main' of https://github.com/meetbhalodi11/ngx-stories
302eb4f
@vercel Vercel
Copy link

vercel bot commented Oct 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ngx-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 5:49am

github-actions[bot]
github-actions bot reviewed Oct 12, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @meetbhalodi11, Thanks for contributing and Congrats on opening PR 🎉.

We will try to review as soon as possible and a maintainer will get back to you soon!

@Gauravdarkslayer
Copy link
Owner

Hey @meetbhalodi11 ,
Thanks for raising this valuable PR, and the implementation looks good as well.
One thing i would like to suggest from design perspective is currently the next & previous buttons are not visible properly, so can you update the icons similar to this https://dwello.in/webstory/12-prime-residential-projects-in-mumbai ?

@meetbhalodi11
Copy link
Contributor Author

Looks great. We can do that

ftr: Add left/right arrow buttons on desktop view only
4432301 
Changed next/previous buttons as per requirements
Gauravdarkslayer
Gauravdarkslayer reviewed Oct 12, 2024
View reviewed changes
Copy link
Owner

@Gauravdarkslayer Gauravdarkslayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment for button added

@Gauravdarkslayer
Copy link
Owner

Thanks for doing the change 🎉 @meetbhalodi11

@Gauravdarkslayer Gauravdarkslayer merged commit f3de1fd into Gauravdarkslayer:main Oct 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Gauravdarkslayer Gauravdarkslayer Gauravdarkslayer approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💡 [REQUEST] - Add left/right arrow buttons on desktop view only
2 participants
@meetbhalodi11 @Gauravdarkslayer