Comments Added #49
Comments Added #49
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @saurabhk9919, Thanks for contributing and Congrats on opening PR 🎉.
We will try to review as soon as possible and a maintainer will get back to you soon!
|
Hey @saurabhk9919 , |
src/app/app.component.html
Outdated
| <!-- | ||
| The ngx-stories component displays a series of stories | ||
| based on the storyGroups array provided from the AppComponent. | ||
| --> |
There was a problem hiding this comment.
Can we please avoid this?
src/app/app.component.ts
Outdated
| @@ -1,14 +1,21 @@ | |||
| // Import necessary modules from Angular and NgxStories library | |||
There was a problem hiding this comment.
Please remove this comment.
src/app/app.component.ts
Outdated
| import { Component } from '@angular/core'; | ||
| import { NgxStoriesComponent, StoryGroup } from '../../projects/ngx-stories/src/public-api'; | ||
|
|
||
| // Define the AppComponent with metadata like selector, template, and style URL |
There was a problem hiding this comment.
Please remove this comment.
src/app/app.component.ts
Outdated
| imports: [NgxStoriesComponent], | ||
| templateUrl: './app.component.html', | ||
| styleUrl: './app.component.css', | ||
| selector: 'app-root', // The component's HTML tag |
There was a problem hiding this comment.
Please remove this comments(present in @component declaration)
src/index.html
Outdated
| w[l] = w[l] || []; w[l].push({ | ||
| 'gtm.start': | ||
| new Date().getTime(), event: 'gtm.js' | ||
| w[l] = w[l] || []; w[l].push({ //pushing the data to the dataLayer |
There was a problem hiding this comment.
Please remove this comment.
src/index.html
Outdated
| new Date().getTime(), event: 'gtm.js' | ||
| w[l] = w[l] || []; w[l].push({ //pushing the data to the dataLayer | ||
| 'gtm.start': | ||
| new Date().getTime(), event: 'gtm.js' //for the first script element in the document |
There was a problem hiding this comment.
Please remove this comment.
src/index.html
Outdated
| <noscript><iframe src="https://www.googletagmanager.com/ns.html?id=GTM-KDD8ZZFP" height="0" width="0" | ||
| style="display:none;visibility:hidden"></iframe></noscript> | ||
| <noscript><iframe src="https://www.googletagmanager.com/ns.html?id=GTM-KDD8ZZFP" height="0" width="0" | ||
| style="display:none;visibility:hidden"></iframe></noscript> //If the script is not supported by the browser then it will display the message |
There was a problem hiding this comment.
Please remove this comment.
src/main.ts
Outdated
| @@ -2,5 +2,7 @@ import { bootstrapApplication } from '@angular/platform-browser'; | |||
| import { appConfig } from './app/app.config'; | |||
| import { AppComponent } from './app/app.component'; | |||
|
|
|||
| // Bootstrapping (initializing) the Angular application with the root component (AppComponent) | |||
There was a problem hiding this comment.
Please remove this comment.
|
@Gauravdarkslayer I have made the changes as instructed in the next commit, you can review the changes |
| currentStoryGroupIndex: number, | ||
| currentStoryIndex: number, | ||
| onStoryGroupChange: (storyGroupIndex: number) => void): { storyGroupIndex: number, storyIndex: number } { | ||
| let stories = storyGroups[currentStoryGroupIndex]?.stories; | ||
| if (currentStoryIndex === 0) { | ||
| // Move to the previous storyGroup if the current story index is 0 |
There was a problem hiding this comment.
Please retain existing comments
| } else if (direction === 'right') { | ||
| this.isSwipingRight = true; | ||
| setTimeout(() => { | ||
| this.goToPreviousStoryGroup(); | ||
| this.resetSwipe(); | ||
| }, 600); // Match the animation duration |
There was a problem hiding this comment.
Please keep existing comments
|
@Gauravdarkslayer I have retained back the missed out comments |
|
Can you please check why builds are failing, may be you can try running the project before creating a commit. |
|
@Gauravdarkslayer I am unable to solve the build issue but the local run is working properly |
Added comments as per instructions