Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to upgrade gradle to 2024.3 #56

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

feldoh
Copy link
Contributor

@feldoh feldoh commented Nov 17, 2024

No description provided.

@feldoh
Copy link
Contributor Author

feldoh commented Nov 17, 2024

Don't merge, this doesn't work but it does at least import properly

@feldoh
Copy link
Contributor Author

feldoh commented Nov 17, 2024

I think it's probably best to just start again with a fresh project based on one of the new kotlin dsl files. I tried for a few hours to keep the groovy dsl. I've got it importing no problem but like you said the run conf stuff just doesn't work. The rider-model.jar straight up doesn't exist in the latest version and I don't know what that is so I'm unclear how to replace it, I repointed at just rd.jar but idk if that's the same thing. Even the new examples point at rider-model.jar so unless it's being generated by some other generator step I'm lost I'm afraid, it's very unclear what generates that if anything as is tradition with gradle nonsense. I'd have tried to migrate to the new one but idk what bits you added and the unity one is enormous.

It's so bizzare

Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath:
    class com.jetbrains.rider.plugins.unity.run.configurations.UnityAttachProfileState, unresolved supertypes: com.jetbrains.rider.run.configurations.remote.MonoConnectRemoteProfileState
    class com.jetbrains.rider.plugins.unity.run.configurations.UnityConfigurationFactoryBase, unresolved supertypes: com.jetbrains.rider.run.configurations.DotNetConfigurationFactoryBase
    class com.jetbrains.rider.plugins.unity.run.configurations.UnityPlayerDebugConfiguration, unresolved supertypes: com.jetbrains.rider.run.configurations.AsyncRunConfiguration, com.jetbrains.rider.debugger.IRiderDebuggable

@Garethp
Copy link
Owner

Garethp commented Nov 17, 2024

Yeah, that's what I was getting to as well. Cloning the rider-unity project does show that whatever setup they've got will resolve those classes, so I know it's not something where it's only working because they've got access to internal sources or something. So best bet I've got is to just copy the DSL from the starter kit and then copy things in from the rider-unity project until it starts working

@feldoh
Copy link
Contributor Author

feldoh commented Nov 17, 2024

It's just so strange because you can get the list of bundled plugins and none of them seem to have the needed deps, nor do the working ones add additional deps I can see it's making a custom configuration to pass through the model jar but that isn't even there on the filesystem so it feels like trying to find a dep when there's clearly a gen step I've missed is a bit of a lost cause

@feldoh
Copy link
Contributor Author

feldoh commented Nov 17, 2024

I'm sure it's solvable but honestly it looks like everything's doing the kotlin route and it's probably worth just taking the hit now. The kotlin one at least has decent autocomplete assist in ide

@Garethp
Copy link
Owner

Garethp commented Nov 17, 2024

Yup, that's my plan. The gradle file I'm using is just what they had in their original template project so I'm more than happy to just overwrite it with the kotlin suggested one and go from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants