Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加网络扩展 #208

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

添加网络扩展 #208

wants to merge 21 commits into from

Conversation

WP-Studio01
Copy link

一个让作品可以访问网络的扩展

Copy link
Contributor

@FurryR FurryR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gandi IDE 不允许任何形式的外链请求。

此外,同步 XMLHttpRequest 也是被明令禁止的。

@WP-Studio01
Copy link
Author

WP-Studio01 commented Mar 24, 2024

Gandi IDE 不允许任何形式的外链请求。

此外,同步 XMLHttpRequest 也是被明令禁止的。

? 什么意思
还有同步xhr怎么你了

@DilemmaGX
Copy link
Contributor

Gandi IDE 不允许任何形式的外链请求。
此外,同步 XMLHttpRequest 也是被明令禁止的。

? 什么意思

说白了就是过不了审,安全性问题吧啦吧啦之类的

@FurryR
Copy link
Contributor

FurryR commented Mar 24, 2024

Gandi IDE 不允许任何形式的外链请求。
此外,同步 XMLHttpRequest 也是被明令禁止的。

? 什么意思 还有同步xhr怎么你了

所有带外链的扩展均过不了审。
同步 XHR 会导致整个页面卡顿(引擎冻结)更加不会过审了。

@WP-Studio01
Copy link
Author

Gandi IDE 不允许任何形式的外链请求。
此外,同步 XMLHttpRequest 也是被明令禁止的。

? 什么意思 还有同步xhr怎么你了

所有带外链的扩展均过不了审。 同步 XHR 会导致整个页面卡顿(引擎冻结)更加不会过审了。

but,异步回调的hat参数到底怎么做

Copy link
Contributor

@sylarhcn sylarhcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果是访问 ccw.site 之外的域名,请提供白名单功能设计。
这样我可以判断这个扩展是否会带来内容审查风险

Copy link
Contributor

@sylarhcn sylarhcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外,文件夹名字请于你的扩展名字一样。bat 文件也不用传上来吧

@WP-Studio01
Copy link
Author

另外,文件夹名字请于你的扩展名字一样。bat 文件也不用传上来吧

az忘记删了

Copy link
Contributor

@MoreBugOfDog MoreBugOfDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I am only a user of Gandi-IDE, my suggestions do not affect the outcome of the review, please refer to the official reviewer's comments for specific requirements.

// 'NetworkExt.sendasyncreq': '发送异步请求,方法为[method],主体为(没有填null)[body],url为[url]',
// 'NetworkExt.seturl': '设置异步请求url[url]',
// 'NetworkExt.whenasync': '当异步请求结束',
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not done?
(Just asking, it doesn't affect the outcome of the audit)

'NetworkExt.httpget': 'GET method synchronization request [url]',
'NetworkExt.httppost': 'POST method synchronization request [url] request body [body]',
'NetworkExt.encoding': 'json转换uri编码字符串[json]',
'NetworkExt.decoding': 'uri编码字符串转换json[uri]',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there some English translations in Chinese?

// insetIconURL: cover,
featured: true,
disabled: false,
collaborator: 'Helloworld@CCW',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommendation:
HELLOWORD @ CCW
(add spaces where appropriate to improve readability)

@MoreBugOfDog
Copy link
Contributor

There are extensions on Turbowarp that are similar to your extension, it is recommended to try to carry the adaptation first and add a security clearance (whitelist)
extensions.turbowarp.org/true-fantom/network.js

@MoreBugOfDog
Copy link
Contributor

Gandi IDE 不允许任何形式的外链请求。
此外,同步 XMLHttpRequest 也是被明令禁止的。

? 什么意思 还有同步xhr怎么你了

所有带外链的扩展均过不了审。 同步 XHR 会导致整个页面卡顿(引擎冻结)更加不会过审了。

but,异步回调的hat参数到底怎么做

https://www.runoob.com/js/js-promise.html
Try reading the Rookie Tutorial
Promise is supported by modern browsers (ES6) and you can use it to。

@DannyDevPro
Copy link
Contributor

网络扩展过不了 你甚至可以翻一番已经关闭的pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants