Fix mob display name in boss bar #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlhlm
added
the
ongoing freeze - do not merge
wlhlm
changed the title
|
Would it be possible to move the name down a little bit so that it doesn't overlap the HP bar? That's always been moderately annoying to me. |
|
Can do that, but in a different PR. |
Dream-Master
removed
the
ongoing freeze - do not merge
The old logic never found a correct translation except for vanilla mobs
wlhlm
force-pushed
the
fix-infernal-mobs-display-name
branch
from
285f4c4 to
311d929
Compare
OneEyeMaker
approved these changes
Dec 9, 2024
29 tasks
Dream-Master
pushed a commit
that referenced
this pull request
Dec 9, 2024
(cherry picked from commit 1f3038b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been an issue for a long time. The boss bar Infernal Mobs essentially used the class name for everything except for vanilla mobs.
Before:
After:
We can merge this after 2.7 as it's been like this forever and I don't want to accidentally break anything during the freeze.