Upgrade terraform cloudgov domain

[jskinne3]

Upgrade terraform-cloudgov in the last spot: the code block that governs our domain name. There is a hitch:

⚠️ This block is hard to test directly. There is some risk in this PR because it is a "test in production" situation ultimately. I did do my best to test it in an indirect way in the Sandbox.

Bonus, nix a stray unused variable from the development module

Part of issue GSA/notifications-api#1139

[github-actions]

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan

null_resource.prevent_destroy: Refreshing state... [id=1728082765789994772]
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 1s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 1s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=d67c8c05-f22b-4fca-ba0b-312af08a61eb]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.redis-v70.data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=13ac7990-e80e-4c07-8208-f6736a87c1d2]
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 1s [id=89c9b6a9-f030-4752-b30f-6b3193a25148]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 1s [id=5d983d08-5079-4159-8721-67edf948d345]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=45c461a7-cc6c-c60d-cea7-1f5480589b64]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Pusher: @jskinne3, Action: pull_request

[ccostino]

Thanks, @jskinne3! This looks like it should be fine based on the changes here.