introduce user constraints #743

wandmagic · 2024-10-01T11:34:45Z

Committer Notes

Introduce constraints on the user object

All Submissions:

Have you selected the correct base branch per Contributing guidance?
Have you set "Allow edits and access to secrets by maintainers"?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you squashed any non-relevant commits and commit messages? [instructions]
Have you added an explanation of what your changes do and why you'd like us to include them?
If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.?
If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

aj-stein-gsa · 2024-10-03T17:37:35Z

I wil review this, but you do want me as assignee, but a review (I am in the fedramp-admins groups FYI). I am just always in a state of being perpetually behind! 😆

Rene2mt

@wandmagic should these constraints be updated w/ help-text and help-urls per ADR 9?

wandmagic · 2024-10-04T13:33:16Z

@wandmagic should these constraints be updated w/ help-text and help-urls per ADR 9?

Added help props and improved messages to include violating UUID

kindly let me know if the URI's i've chosen are appropriate

src/validations/constraints/fedramp-external-constraints.xml

aj-stein-gsa

Looks good so far, just asking to use the URLs for now. help-text and help-markdown can come later.

src/validations/constraints/fedramp-external-constraints.xml

wandmagic · 2024-10-04T18:04:47Z

Looks good so far, just asking to use the URLs for now. help-text and help-markdown can come later.

ok should be in there now

needs another look

src/validations/constraints/fedramp-external-constraints.xml

aj-stein-gsa

Apologies for the delayed review.

This is very good work, but we may need to touch a few things up in regards to the documentation URLs generally and also more recent constraint style guide requirements.

src/validations/constraints/fedramp-external-constraints.xml

Co-authored-by: A.J. Stein <[email protected]>

…ic/fedramp-automation into feature/user-constraints

kyhu65867

You can also resolve this without changes if you really want to but I think what I said should be considered

src/validations/constraints/content/ssp-user-has-authorized-privilege-INVALID.xml

aj-stein-gsa

Really solid work as always, can we discuss fixing this up and readying it to go. I am sorry I missed one bit of this potentially in doc review, so we will need to circle back.

src/validations/constraints/content/ssp-all-VALID.xml

src/validations/constraints/fedramp-external-allowed-values.xml

Co-authored-by: A.J. Stein <[email protected]>

out of date

aj-stein-gsa · 2024-10-30T19:45:26Z

@wandmagic can you please update the checklist so when a third review comes in, we can approve and merge? Thanks.

Gabeblis

LGTM

* introduce user constraints * introduce help props * adjust help uri coverage * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: A.J. Stein <[email protected]> * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: A.J. Stein <[email protected]> * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: A.J. Stein <[email protected]> * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: A.J. Stein <[email protected]> * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: A.J. Stein <[email protected]> * see GSA/automate.fedramp.gov#98 * merge same invalid samples * Update user-type-FAIL.yaml * Update user-type-FAIL.yaml * update tests * Update src/validations/constraints/fedramp-external-allowed-values.xml Co-authored-by: A.J. Stein <[email protected]> * Update src/validations/constraints/content/ssp-all-VALID.xml Co-authored-by: A.J. Stein <[email protected]> * update tests --------- Co-authored-by: A.J. Stein <[email protected]>

wandmagic requested a review from a team as a code owner October 1, 2024 11:34

wandmagic assigned wandmagic and aj-stein-gsa Oct 3, 2024

aj-stein-gsa removed their assignment Oct 3, 2024

Rene2mt previously requested changes Oct 3, 2024

View reviewed changes

wandmagic requested a review from Rene2mt October 4, 2024 13:33

wandmagic force-pushed the feature/user-constraints branch from 6afe441 to f4d4bb8 Compare October 4, 2024 13:46

aj-stein-gsa reviewed Oct 4, 2024

View reviewed changes

src/validations/constraints/fedramp-external-constraints.xml Outdated Show resolved Hide resolved

aj-stein-gsa reviewed Oct 4, 2024

View reviewed changes

src/validations/constraints/fedramp-external-constraints.xml Outdated Show resolved Hide resolved

wandmagic force-pushed the feature/user-constraints branch from ae0b569 to 92dbcff Compare October 21, 2024 11:36

wandmagic requested a review from a team as a code owner October 21, 2024 11:36

wandmagic and others added 3 commits October 21, 2024 07:36

introduce user constraints

8f1a282

introduce help props

e8bddef

adjust help uri coverage

92dbcff

DimitriZhurkin reviewed Oct 21, 2024

View reviewed changes

src/validations/constraints/fedramp-external-constraints.xml Show resolved Hide resolved

aj-stein-gsa requested changes Oct 24, 2024

View reviewed changes

wandmagic and others added 7 commits October 24, 2024 13:03

Update src/validations/constraints/fedramp-external-constraints.xml

42bbced

Co-authored-by: A.J. Stein <[email protected]>

Update src/validations/constraints/fedramp-external-constraints.xml

20856b0

Co-authored-by: A.J. Stein <[email protected]>

Update src/validations/constraints/fedramp-external-constraints.xml

c61b93d

Co-authored-by: A.J. Stein <[email protected]>

Update src/validations/constraints/fedramp-external-constraints.xml

06d7e80

Co-authored-by: A.J. Stein <[email protected]>

Update src/validations/constraints/fedramp-external-constraints.xml

660e094

Co-authored-by: A.J. Stein <[email protected]>

see GSA/automate.fedramp.gov#98

43fd185

Merge branch 'feature/user-constraints' of https://github.com/wandmag…

f0bd660

…ic/fedramp-automation into feature/user-constraints

kyhu65867 previously requested changes Oct 25, 2024

View reviewed changes

src/validations/constraints/content/ssp-user-has-authorized-privilege-INVALID.xml Outdated Show resolved Hide resolved

wandmagic added 2 commits October 25, 2024 10:12

merge same invalid samples

f675069

Update user-type-FAIL.yaml

2eed10f

wandmagic added 3 commits October 25, 2024 10:22

Update user-type-FAIL.yaml

c97dba4

Merge branch 'develop' into feature/user-constraints

11b2009

update tests

47968cb

aj-stein-gsa requested changes Oct 29, 2024

View reviewed changes

src/validations/constraints/content/ssp-all-VALID.xml Outdated Show resolved Hide resolved

src/validations/constraints/fedramp-external-allowed-values.xml Outdated Show resolved Hide resolved

wandmagic and others added 3 commits October 29, 2024 16:34

Update src/validations/constraints/fedramp-external-allowed-values.xml

6e225e6

Co-authored-by: A.J. Stein <[email protected]>

Update src/validations/constraints/content/ssp-all-VALID.xml

59c7007

Co-authored-by: A.J. Stein <[email protected]>

update tests

d39421a

aj-stein-gsa approved these changes Oct 30, 2024

View reviewed changes

DimitriZhurkin approved these changes Oct 30, 2024

View reviewed changes

aj-stein-gsa requested a review from kyhu65867 October 30, 2024 15:39

wandmagic requested a review from Gabeblis October 30, 2024 18:59

Gabeblis approved these changes Oct 31, 2024

View reviewed changes

aj-stein-gsa merged commit 5cb7351 into GSA:develop Oct 31, 2024
5 checks passed

This was referenced Nov 13, 2024

develop #900

Closed

chore update container oscal cli js 20241113 #901

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

introduce user constraints #743

introduce user constraints #743

wandmagic commented Oct 1, 2024 •

edited

Loading

aj-stein-gsa commented Oct 3, 2024

Rene2mt left a comment

wandmagic commented Oct 4, 2024

aj-stein-gsa left a comment

wandmagic commented Oct 4, 2024

aj-stein-gsa left a comment

kyhu65867 left a comment

aj-stein-gsa left a comment

aj-stein-gsa commented Oct 30, 2024

Gabeblis left a comment

introduce user constraints #743

introduce user constraints #743

Conversation

wandmagic commented Oct 1, 2024 • edited Loading

Committer Notes

All Submissions:

aj-stein-gsa commented Oct 3, 2024

Rene2mt left a comment

Choose a reason for hiding this comment

wandmagic commented Oct 4, 2024

aj-stein-gsa left a comment

Choose a reason for hiding this comment

wandmagic commented Oct 4, 2024

aj-stein-gsa left a comment

Choose a reason for hiding this comment

kyhu65867 left a comment

Choose a reason for hiding this comment

aj-stein-gsa left a comment

Choose a reason for hiding this comment

aj-stein-gsa commented Oct 30, 2024

Gabeblis left a comment

Choose a reason for hiding this comment

wandmagic commented Oct 1, 2024 •

edited

Loading