Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Profile fix issue 1093 #1131

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Conversation

Rene2mt
Copy link
Member

@Rene2mt Rene2mt commented Jan 23, 2025

Committer Notes

This PR addresses issue #1093, removing the aggregate parameters, and replacing them with the aggregated ODPs instead. These changes are being applied on the following profiles:

  • FR High profile
  • FR Moderate profile
  • FR Low profile
  • FR LI-SaaS profile

NOTE - While updating the profiles, I noticed they currently contain some references to the JAB. This PR is only scoped to the aggregate param replacement by ODPs though, and follow on work will remove the JAB references unless we want to address those changes in this PR.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Rene2mt Rene2mt changed the title [DO NOT MERGE] WIP PR - Profile fix issue 1093 PR - Profile fix issue 1093 Jan 23, 2025
@Rene2mt Rene2mt marked this pull request as ready for review January 23, 2025 20:55
@Rene2mt Rene2mt requested a review from a team as a code owner January 23, 2025 20:55
@Rene2mt Rene2mt linked an issue Jan 23, 2025 that may be closed by this pull request
12 tasks
wandmagic
wandmagic previously approved these changes Jan 24, 2025
Copy link

@wandmagic wandmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good nice work!

@aj-stein-gsa aj-stein-gsa dismissed stale reviews from wandmagic and themself via 52f3142 January 24, 2025 14:34
@aj-stein-gsa aj-stein-gsa merged commit 8c9fa76 into GSA:develop Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FedRAMP Baselines Move Constraints From Aggregated Parameters
3 participants