Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inventory-item-has-asset-type Constraint #1078

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Jan 8, 2025

Committer Notes

Purpose

This PR aims to add the inventory-item-has-asset-type constraint which ensures that each inventory item, or it's linked component, has the "asset-type" prop.

Changes

Added constraint:

  • inventory-item-has-asset-type

Added invalid test content:

  • ssp-inventory-item-has-is-scanned-INVALID.xml

Added yaml files for testing:

  • Pass/fail yaml tests added for each of the above constraints.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Jan 8, 2025
@Gabeblis Gabeblis requested a review from a team as a code owner January 8, 2025 15:33
@Gabeblis Gabeblis linked an issue Jan 8, 2025 that may be closed by this pull request
15 tasks
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!! Will need a rebase before merging though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory - Asset Type
3 participants