Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inventory-item-or-component-has-network constraint #1065

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Jan 6, 2025

Committer Notes

Purpose

This PR aims to add the inventory-item-or-component-has-network constraint which ensures that each inventory item or internal service component is reachable via a network, which requires either an IPv4 address, IPv6 address, fully qualified domain name (FQDN) or uniform resource identifier (URI).

Changes

Added constraint:

  • inventory-item-or-component-has-network

Added valid/invalid test content:

  • ssp-inventory-item-or-component-has-network-INVALID.xml
  • Edited fedramp-ssp-example.oscal.xml to align with constraint

Added yaml files for testing:

  • Pass/fail yaml tests added for each of the above constraints.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Jan 6, 2025
@Gabeblis Gabeblis requested a review from a team as a code owner January 6, 2025 14:06
@Gabeblis Gabeblis linked an issue Jan 6, 2025 that may be closed by this pull request
16 tasks
@Gabeblis
Copy link
Contributor Author

Gabeblis commented Jan 6, 2025

@Rene2mt As of right now, upstream allowed-values don't allow for a "ipv4-address", "ipv6-address", "fqdn", or "uri" prop in an internal service component. This constraint is blocked.

@wandmagic
Copy link

@Rene2mt As of right now, upstream allowed-values don't allow for a "ipv4-address", "ipv6-address", "fqdn", or "uri" prop in an internal service component. This constraint is blocked.

unfortunate we can't add them in? how can we get unblocked here?

@Gabeblis Gabeblis changed the base branch from develop to canary January 7, 2025 18:13
@Gabeblis Gabeblis requested review from wandmagic and Rene2mt January 7, 2025 18:35
@Gabeblis Gabeblis force-pushed the constraints/issue-1025 branch 2 times, most recently from 7c62301 to 1765b26 Compare January 9, 2025 17:14
wandmagic
wandmagic previously approved these changes Jan 10, 2025
Copy link

@wandmagic wandmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constraint looks good, we can keep it in canary while its blocked upstream

@Gabeblis Gabeblis force-pushed the constraints/issue-1025 branch 2 times, most recently from 72740ed to 9cf0c60 Compare January 14, 2025 15:25
@Gabeblis Gabeblis force-pushed the constraints/issue-1025 branch from 9cf0c60 to 85e8c9b Compare January 14, 2025 15:35
@Gabeblis Gabeblis requested a review from wandmagic January 14, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory - IP or DNS Information
2 participants