Removes obsolete or redundant guides #966
Conversation
brentryanjohnson
requested review from
jfredrickson,
mark-meyer and
vickimcfadden
There was a problem hiding this comment.
@mark-meyer and/or @jfredrickson I removed this filter because we don't need it for the limited guides we're keeping. Could one of you review this? I suspect there's more to this change than the markup.
layouts/guides/list.html
Outdated
| @@ -7,24 +7,7 @@ <h1>GSA Tech Guides</h1> | |||
| {{ .Content }} | |||
|
|
|||
| <div class="grid-row grid-gap"> | |||
There was a problem hiding this comment.
Hey @brentryanjohnson — I think we can delete the grid divs altogether since we no longer have columns to worry about. So deleting this div and the one below, which will promote the one <div class="guides-category" data-category="{{ .Key | urlize }}"> to the top level.
layouts/guides/list.html
Outdated
| </div> | ||
| </div> | ||
|
|
||
|
|
||
| <div class="tablet:grid-col-9"> | ||
| {{ range .Pages.GroupByParam "category" }} |
There was a problem hiding this comment.
I think it's fine to keep this even thought there is only one category…but just pointing out that if we'll never have anything other than Agile, we could simplify this too.
Fixes #884