-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(setup): First draft for the tomcat 10, war setup example. #1920
Conversation
2f0d6c8
to
4c308fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice documentation! I checked the equality of both languages and the links and made small suggestions. Everything is very plausible to me and fits the setup we were recently setting up twice, as far as I remember. I did not try the steps again within this review - but I assume you checked this...?
fd22fda
to
22e9dd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an explanation for v8.2.0 - as such, it should live there, as soon as versioning is merged.
The config shouldn't be touched, except where it adds the new files.
Once comments from the english version are introduced, they have to be synced to the german version as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Jochen Häußler <[email protected]>
Co-authored-by: Jakob Schnell <[email protected]>
f080b42
to
2613540
Compare
docs/versions/v8.2.0/run-instance/example-setups/de_tomcat-10-ubuntu_22_04.md
Outdated
Show resolved
Hide resolved
docs/versions/v8.2.0/run-instance/example-setups/en_tomcat-10-ubuntu_22_04.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jochen Häußler <[email protected]>
Co-authored-by: Jochen Häußler <[email protected]>
…ubuntu_22_04.md Co-authored-by: Jochen Häußler <[email protected]>
…ubuntu_22_04.md Co-authored-by: Jochen Häußler <[email protected]>
Quality Gate passedIssues Measures |
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)