fix(logging): Repair the logging backend #1695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the exclusion of log4j-slf4j2-impl (therefore including it) and removes the package slf4j-reload4j.
Graphhopper uses slf4j as a logging backend, whereas ors uses log4j.
We need log4j-slf4j2-impl to tunnel slf4j through our log4j logging interface. This is not 100% evident in all run scenarios. While native spring runs can cope with this partially, running in an external tomcat environment leads to no or missing log output once the war is deployed.
We don't need slf4j-reload4j right now, as it would only be useful for hot-reloading logging configs while ors is running. Another side effect of just keeping the lib is that when spring or tomcat is looking for a log facility, it sees log4j as well as slf4j-reload4j. It can happen, that it appends to slf4j-reload4j instead of log4j in certain scenarios, which leads to no available logging output. This confusion can lead to no log output in tomcat/war deployment scenarios.
Additionally, a redundant exclusion is removed as well as the missing spring-boot-starter-validation included.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)