Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove logging configuration #1679

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

takb
Copy link
Contributor

@takb takb commented Feb 5, 2024

Information about the changes

  • Reason for change:
    Logging used to have a separate log4j configuration file, we get rid of those since using the standard spring logging configuration instead should suffice for our needs.
    Also removing an old log4j configuration used for the Tomcat in the docker setup.

logging used to have a separate log4j configuration file, we get rid of those since using the standard spring logging configuration instead should suffice for our needs.
@takb takb requested a review from MichaelsJP February 5, 2024 12:12
@github-actions github-actions bot added refactor and removed refactor labels Feb 5, 2024
@takb takb force-pushed the refactor/remove-logging-configuration branch from 53206b3 to a0fd70b Compare February 5, 2024 13:26
Copy link
Member

@MichaelsJP MichaelsJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelsJP MichaelsJP merged commit 2917d8b into main Feb 5, 2024
17 checks passed
@MichaelsJP MichaelsJP deleted the refactor/remove-logging-configuration branch February 5, 2024 17:21
selimguvenc pushed a commit to selimguvenc/openrouteservice that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Awaiting release
Development

Successfully merging this pull request may close these issues.

2 participants