feat: config cleanup finalize #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault disabled profiles
…rs-config.yml This feature intents to keep the application.yml and the ors-config.yml in sync. The ors-config.yml is intented as a minimal working configuration for users that want an up and running system without configuration. The in-depth configs are still in the ors-config.yml but commented out. The sync script will make sure in a workflow that if the original application.yml changes, the ors-config.yml mirrors the new changes but commented out.
sfendrich
requested changes
Jan 30, 2024
ors-api/src/main/java/org/heigit/ors/api/ORSEnvironmentPostProcessor.java
Outdated
Show resolved
Hide resolved
ors-api/src/main/java/org/heigit/ors/api/servlet/listeners/ORSInitContextListener.java
Outdated
Show resolved
Hide resolved
The workflow is triggered on PRs for main and releases/** branches if the PR is set for review or synchronized.
Some prior changes got overwritten. This introduces the old state as well as an additional testing if the config is actually in the right format to be parsed.
To allow a smooth conversion of the application.yml the source_file parameter needs to be next after engine:. Else, awk operations will just become unnecessary tedious.
The old dockerfile was coined to use the json config. This commit just makes sure everything works again. The whole setup will probably get a revamp before release anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)