Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Data Access): Remove unused methods #1643

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

rtroilo
Copy link
Member

@rtroilo rtroilo commented Dec 21, 2023

In order to prepare for an update to the DataAccess (gh5+) this PR removes some unused methods which access the in future removed setSegmentSize DataAccess method.

Pull Request Checklist

  • 1. I have rebased the latest version of the master branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes # .

Information about the changes

  • Key functionality added:
  • Reason for change:

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

@rtroilo rtroilo force-pushed the feature/dataaccess_remove_unused_methods branch from f2af58d to ed67702 Compare December 21, 2023 11:23
@rtroilo rtroilo requested a review from takb December 21, 2023 11:24
@github-actions github-actions bot added feature and removed feature labels Dec 21, 2023
@rtroilo rtroilo force-pushed the feature/dataaccess_remove_unused_methods branch 2 times, most recently from 39e5375 to 87a3162 Compare December 21, 2023 12:56
@github-actions github-actions bot added feature and removed feature labels Dec 21, 2023
@MichaelsJP MichaelsJP changed the title feat(Data Access): Remove unused methods refactor(Data Access): Remove unused methods Jan 9, 2024
@github-actions github-actions bot added refactor and removed feature labels Jan 9, 2024
@MichaelsJP MichaelsJP force-pushed the feature/dataaccess_remove_unused_methods branch from 87a3162 to 3a91746 Compare January 9, 2024 14:04
@MichaelsJP MichaelsJP added the easy-fix 👶 very easy fix that should not take much time label Jan 9, 2024
Copy link
Contributor

@sfendrich sfendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sfendrich sfendrich merged commit 64372da into master Jan 17, 2024
12 checks passed
@sfendrich sfendrich deleted the feature/dataaccess_remove_unused_methods branch January 17, 2024 08:04
@MichaelsJP MichaelsJP added this to the V8 Release milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy-fix 👶 very easy fix that should not take much time refactor
Projects
No open projects
Status: Awaiting release
Development

Successfully merging this pull request may close these issues.

3 participants