build(maven): Move the war/jar logic to the main pom.xml

This allows us to use the packagingValue inside the ors-report-aggregation as well and build it in jar/war mode. Before, we always needed to exclude the package when building with war target.
GIScience · Feb 19, 2024 · 9cbadb4 · 9cbadb4
1 parent 3c9f57f
commit 9cbadb4
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 25 deletions.
diff --git a/ors-api/pom.xml b/ors-api/pom.xml
@@ -39,15 +39,6 @@
 
     <packaging>${packagingValue}</packaging>
 
-    <properties>
-        <!--
-            A default for packagingValue is needed, if profiles other than buildWar or buildFatJar are used, e.g. apitests.
-            The value is set/overridden in the profiles buildWar and buildFatJar, e.g.
-                mvn clean package -PbuildWar
-         -->
-        <packagingValue>jar</packagingValue>
-    </properties>
-
     <build>
         <finalName>ors</finalName>
         <sourceDirectory>src/main/java</sourceDirectory>
@@ -290,21 +281,6 @@
     </dependencies>
 
     <profiles>
-        <profile>
-            <id>buildWar</id>
-            <properties>
-                <packagingValue>war</packagingValue>
-            </properties>
-        </profile>
-        <profile>
-            <id>buildFatJar</id>
-            <properties>
-                <packagingValue>jar</packagingValue>
-            </properties>
-            <activation>
-                <activeByDefault>true</activeByDefault>
-            </activation>
-        </profile>
         <profile>
             <id>apitests</id>
             <build>

diff --git a/ors-report-aggregation/pom.xml b/ors-report-aggregation/pom.xml
@@ -23,7 +23,7 @@
             <groupId>org.heigit.ors</groupId>
             <artifactId>ors-api</artifactId>
             <version>${project.version}</version>
-            <type>jar</type>
+            <type>${packagingValue}</type>
         </dependency>
     </dependencies>
 

diff --git a/pom.xml b/pom.xml
@@ -33,6 +33,12 @@
     </modules>
 
     <properties>
+        <!--
+            A default for packagingValue is needed, if profiles other than buildWar or buildFatJar are used, e.g. apitests.
+            The value is set/overridden in the profiles buildWar and buildFatJar, e.g.
+                mvn clean package -PbuildWar
+         -->
+        <packagingValue>jar</packagingValue>
         <java.version>17</java.version>
         <maven.compiler.source>${java.version}</maven.compiler.source>
         <maven.compiler.target>${java.version}</maven.compiler.target>
@@ -81,6 +87,24 @@
         </repository>
     </repositories>
 
+    <profiles>
+        <profile>
+            <id>buildWar</id>
+            <properties>
+                <packagingValue>war</packagingValue>
+            </properties>
+        </profile>
+        <profile>
+            <id>buildFatJar</id>
+            <properties>
+                <packagingValue>jar</packagingValue>
+            </properties>
+            <activation>
+                <activeByDefault>true</activeByDefault>
+            </activation>
+        </profile>
+    </profiles>
+
     <dependencyManagement>
         <dependencies>
             <!-- As long as swagger-parser uses snakeyaml <2 it cannot be used. Too much vulnerabilities. -->