-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HepMC3 output according to draft "NuHepMC" standard #333
Open
sjgardiner
wants to merge
35
commits into
GENIE-MC:master
Choose a base branch
from
sjgardiner:hepmc3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implementation of the HepMC3 event record format
…on to the GMCJDriver class
… with its MC statistical uncertainty) of the flux-averaged total cross section
from conversion of the genie::Interaction object's contents in HepMC3 format.
… the full map of kinematic variables
exist at both the start and end of the formation zone in the event record. Add a new particle status code for the copies at the start of the formation zone. Also assign the struck nucleon 4-position to the hadronic system pseudo-particle.
pre-formation-zone hadrons
interface NtpWriterI. This is a step towards supporting arbitrary event output formats, including those which are not ROOT-based
…class produces HepMC3-format files using GHepRecord objects as input
nucleus GHepParticle in slot 1, the struck electron will be listed as its own mother for a NuEElastic reaction on a 1H target
…decay products from Pythia
…rent mother/daughter conventions, etc.
approach is less fragile
…mary vertex as the attribute "LabPos"
hard-coded numbers in favor of named constants for these.
capability is used to report a running estimate of the flux-averaged total cross section in HepMC3-format events
owned by a GMCJDriver object
… and update citation metadata format
…tion and a running estimate of the flux-averaged total cross section together with its statistical uncertainty. Update GMCJDriver to populate these fields for accepted events.
information formerly obtained there from the new fields in the EventRecord itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working code for GENIE review and feedback