-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PistonCrushing #28
Open
FxMorin
wants to merge
40
commits into
1.19.3
Choose a base branch
from
feature/piston-crushing
base: 1.19.3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/resources/pistonlib.accesswidener
I haven't been able to get anything but the single recipes working, and im not sure why |
FxMorin
commented
May 19, 2023
@@ -232,6 +233,10 @@ public boolean triggerEvent(BlockState state, Level level, BlockPos pos, int typ | |||
if (frontBlockEntity instanceof PistonMovingBlockEntity mbe && mbe.getDirection() == facing && mbe.isExtending()) { | |||
mbe.finalTick(); | |||
droppedBlock = true; | |||
} else if (frontBlockEntity instanceof MergeBlockEntity mbe) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge block entity block dropping. Just a comment to myself that I added in this PR for some reason
…hing # Conflicts: # src/main/resources/pistonlib.accesswidener # src/main/resources/pistonlib.mixins.json
- new annotation is currently broken
# Conflicts: # gradle.properties # src/main/java/ca/fxco/pistonlib/base/ModMenus.java # src/main/java/ca/fxco/pistonlib/blocks/pistons/basePiston/BasicPistonBaseBlock.java # src/main/java/ca/fxco/pistonlib/helpers/Utils.java # src/main/java/ca/fxco/pistonlib/network/packets/ClientboundPistonEventPacket.java # src/main/java/ca/fxco/pistonlib/network/packets/PLPacket.java # src/main/java/ca/fxco/pistonlib/pistonLogic/structureResolvers/DebugStructureResolver.java # src/main/resources/pistonlib.accesswidener
Update README
Switch to new GameTest annotation
- Add 1Foxy2 as an author - Update description - Add contact metadata - Update discord invite - Add modmenu github links
Release: `v1.1.0-alpha`
# Conflicts: # src/main/java/ca/fxco/pistonlib/PistonLib.java # src/main/java/ca/fxco/pistonlib/blocks/pistons/basePiston/BasicPistonBaseBlock.java # src/main/java/ca/fxco/pistonlib/datagen/ModRecipeProvider.java # src/main/java/ca/fxco/pistonlib/mixin/entity/Entity_pushIntoMixin.java # src/main/resources/pistonlib.accesswidener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to crush entities/items using pistons.
Huge recipe system to add custom crushing rules, with a very configurable setup. Configurable rule system to adjust crushing rules based on the block the entity is being crushed against.
You are able to crush items together to merge them.
https://github.com/natanfudge/fabric-docs/blob/master/newdocs/Modding-Tutorials/Crafting-Recipes/defining-custom-crafting-recipes.md