-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap BaseIdent
name_override_opt
& TraitName
in an Arc
#5978
Merged
+19
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBatty
added
the
compiler
General compiler. Should eventually become more specific as the issue is triaged
label
May 9, 2024
Benchmark for 0448ab5Click to view benchmark
|
IGI-111
approved these changes
May 9, 2024
kayagokalp
approved these changes
May 9, 2024
Benchmark for 54725e9Click to view benchmark
|
JoshuaBatty
added a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I generated a flame graph and saw that we are spending a ton of time cloning
BaseIdent
andTraitName
. I've wrapped thename_override_opt
in BaseIdent with anArc
and also changed TraitName to:Again running the same test being used in #5976 and also incorporating that PR's optimisations for the benchmark, we are getting a further 33.47% performance increase.
Before: Elapsed time:
22.02603425s
After: Elapsed time:
14.653166459s
In discussions with Jibril today, we should probably look at implementing a String interning system but this can be addressed in a future PR.